Skip to content

fix(router): normalize added routes #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025
Merged

fix(router): normalize added routes #973

merged 2 commits into from
Jun 2, 2025

Conversation

huseeiin
Copy link
Contributor

now you can add h3 routes with arabic letters.

@huseeiin huseeiin requested a review from pi0 as a code owner February 18, 2025 19:02
@huseeiin
Copy link
Contributor Author

@pi0 you might need to rerun prettier because i didn't have time to do that

@pi0 pi0 changed the title fix arabic-based routes feat: encode added routes Feb 19, 2025
@pi0

This comment was marked as outdated.

@pi0 pi0 force-pushed the main branch 2 times, most recently from 348028f to a449d79 Compare April 17, 2025 22:19
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks lets give it a try with URL normalizer and optimize if needed

@pi0 pi0 changed the title feat: encode added routes fix: encode added routes Jun 2, 2025
@pi0 pi0 changed the title fix: encode added routes fix(router): normalize added routes Jun 2, 2025
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@pi0 pi0 merged commit bd79f57 into h3js:main Jun 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants